-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add option to launch mrm handler #929
Merged
isamu-takagi
merged 2 commits into
autowarefoundation:main
from
isamu-takagi:feat/launch-mrm-handler-option
Mar 28, 2024
Merged
feat: add option to launch mrm handler #929
isamu-takagi
merged 2 commits into
autowarefoundation:main
from
isamu-takagi:feat/launch-mrm-handler-option
Mar 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takagi, Isamu <[email protected]>
TetsuKawa
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ito-san
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4swinv
pushed a commit
to 4swinv/autoware_launch
that referenced
this pull request
Apr 9, 2024
Signed-off-by: Takagi, Isamu <[email protected]>
maxime-clem
pushed a commit
to maxime-clem/autoware_launch
that referenced
this pull request
May 21, 2024
Signed-off-by: Takagi, Isamu <[email protected]>
maxime-clem
pushed a commit
to maxime-clem/autoware_launch
that referenced
this pull request
May 21, 2024
…handler * feat: add option to launch mrm handler (autowarefoundation#929) Signed-off-by: Takagi, Isamu <[email protected]> * chore: add option to select graph path depending on running mode (autowarefoundation#938) chore: add option of using graph path for simulation Signed-off-by: Tomohito Ando <[email protected]> * feat: add a param file of a mrm handler node (autowarefoundation#927) Signed-off-by: TetsuKawa <[email protected]> * feat: update config to launch mrm_handler Signed-off-by: Tomohito Ando <[email protected]> * feat(mrm_handler): enable comfortable stop Signed-off-by: Tomohito Ando <[email protected]> --------- Signed-off-by: Takagi, Isamu <[email protected]> Signed-off-by: Tomohito Ando <[email protected]> Signed-off-by: TetsuKawa <[email protected]> Co-authored-by: Takagi, Isamu <[email protected]> Co-authored-by: TetsuKawa <[email protected]>
Ericpotato
pushed a commit
to tier4/autoware_launch
that referenced
this pull request
Nov 6, 2024
chore: sync upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add option to use mrm handler. This option is disabled by default.
https://github.com/orgs/autowarefoundation/discussions/4176
Tests performed
This is a sample parameter.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.